pre-commit: Update pre-commit repo revisions #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pre-commit dependencies to the latest revisions to fix errors when using pre-commit with newer versions of Python (e.g. 3.12). Signed-off-by: Chris Wilson <chris@cgnd.dev>
|
Visit the preview URL for this PR (updated for commit 9a4d4bc): https://golioth-firmware-sdk-doxygen-dev--pr471-cdwilson-updat-kldlwf9q.web.app (expires Mon, 06 May 2024 16:07:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
sam-golioth
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thanks @cdwilson! We can go ahead and merge this one, since it's not an SDK code change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues using
pre-commitlocally w/ Python 3.12, e.g.Auto-upgrading the pre-commit dependencies (
pre-commit autoupdate) to their latest versions fixed these issues.I also had to upgrade the
pre-commitdocker image tokiwicom/pre-commit:3.6.0due to Lucas-C/pre-commit-hooks#83