Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DRONE CI #1833

Closed
manugupt1 opened this issue Feb 25, 2023 · 2 comments · Fixed by #1839
Closed

Remove DRONE CI #1833

manugupt1 opened this issue Feb 25, 2023 · 2 comments · Fixed by #1839
Labels
ci/cd Work to do to improve our CI/CD system dev ux Improvements to the development or operator experience good first issue Great issues for new Athenians to work on!

Comments

@manugupt1
Copy link
Member

manugupt1 commented Feb 25, 2023 •
edited
Loading

Describe the bug
We remove DRONE CI; but it is not completely removed.
It has several references.
https://github.com/search?q=repo%3Agomods%2Fathens%20drone&type=code

We should fix it.

Further we should remove it from:
Automated workflows
#1832
@manugupt1 manugupt1 added good first issue Great issues for new Athenians to work on! ci/cd Work to do to improve our CI/CD system dev ux Improvements to the development or operator experience labels Feb 25, 2023
@r-ashish
Copy link
Member

Also, drone is still showing up on PRs & is marked as required. Not sure where’s that coming from.

There’s also a drone webhook that should now be safe to remove.

@r-ashish
Copy link
Member

Also, drone is still showing up on PRs & is marked as required. Not sure where’s that coming from.

Managed to get rid of this.

For posterity, it was under branch protection rules: https://github.com/gomods/athens/settings/branches.

@nrwiersma nrwiersma mentioned this issue Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci/cd Work to do to improve our CI/CD system dev ux Improvements to the development or operator experience good first issue Great issues for new Athenians to work on!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove last drone remains nrwiersma/athens
2 participants
@manugupt1 @r-ashish