Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: go get should return different errors for "not found" vs "on blacklist" #307

Closed
bketelsen opened this issue Jul 19, 2018 · 3 comments
Labels
proxy Work to do on the module proxy

Comments

@bketelsen
Copy link
Contributor

proxy should return a not found error for a package that isn't found
the error for a package that is on the blacklist should be different from the "not found" error, to allow the go client to discriminate properly between non-existing packages and packages prohibited by proxy policy.

@arschles
Copy link
Member

Agree. Personally I think we should make 403 Forbidden the standard for anything on the exclude list in the proxy

@ghost ghost added the proxy Work to do on the module proxy label Jul 19, 2018
@marwan-at-work
Copy link
Contributor

We should close this issue since we don't return 404s anymore. However, for better performance, we should open a new issue titled "return 404 and asynchronously fill cache" once cmd/go resolves this issue: golang/go#26334

@michalpristas
Copy link
Member

Closing as blacklist returns StatusForbidden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy Work to do on the module proxy
Projects
None yet
Development

No branches or pull requests

4 participants