Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blas: bounds check panic messages do not match netlib/blas #18

Closed
kortschak opened this issue May 25, 2017 · 0 comments
Closed

blas: bounds check panic messages do not match netlib/blas #18

kortschak opened this issue May 25, 2017 · 0 comments

Comments

@kortschak
Copy link
Member

Running the matrix/mat64 TestMul using the netlib CGO blas causes a trivial failure resulting from a difference in messages for bounds check failures; netlib/blas is more informative.

$ CGO_LDFLAGS="-L/usr/local -lopenblas" go test -tags cblas -run TestMul
--- FAIL: TestMul (0.08s)
	dense_test.go:836: expected runtime panic for nil data slice: got "blas: index of c out of range"
	dense_test.go:836: expected runtime panic for nil data slice: got "blas: index of c out of range"
	dense_test.go:836: expected runtime panic for nil data slice: got "blas: index of c out of range"
	dense_test.go:836: expected runtime panic for nil data slice: got "blas: index of c out of range"
	dense_test.go:836: expected runtime panic for nil data slice: got "blas: index of c out of range"
	dense_test.go:836: expected runtime panic for nil data slice: got "blas: index of c out of range"
FAIL

To fix this we need to add an additional name parameter to the checkMatrix* helpers so that the correct message can be panicked on. This is generally useful anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant