Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support follow and filter completion #3

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

polesye
Copy link
Contributor

@polesye polesye commented Jan 22, 2024

The PR adds support of follow and displays filter autocomplete requests.
The logic is copied from sharkd.

82b73e0c-ff18-4164-831c-fe9afbb2f499.mp4

lib/wiregasm/meson.build Outdated Show resolved Hide resolved
@polesye
Copy link
Contributor Author

polesye commented Jan 22, 2024

@dehydr8 I kindly request your review.

@dehydr8
Copy link
Member

dehydr8 commented Jan 22, 2024

Hi @polesye

Thanks for contributing to the project.

I'll review it and leave comments in a while.

lib/wiregasm/lib.cpp Outdated Show resolved Hide resolved
@dehydr8 dehydr8 self-assigned this Jan 22, 2024
@dehydr8
Copy link
Member

dehydr8 commented Jan 23, 2024

Hi @polesye, thanks for addressing the comments. Let me know if you plan to make any more changes in this PR.

@polesye
Copy link
Contributor Author

polesye commented Jan 23, 2024

@dehydr8 no, I'm done at this stage.

@dehydr8 dehydr8 merged commit eb77af9 into good-tools:master Jan 23, 2024
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@polesye polesye deleted the task/extend-follow-completion branch January 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants