add support for relative upload paths in DataStoreService #23
Conversation
| sardine = new SardineImpl(httClientBuilder, user, pass); | ||
| } | ||
|
|
||
| private UriPrefixer getPrefixer() { | ||
| if (prefixer == null) { | ||
| final String webDAVUri = gdcService.getGdc().getLink("uploads").getLink(); | ||
| prefixer = new UriPrefixer(webDAVUri); | ||
| final String uriPrefix = StringUtils.isEmpty(URI.create(webDAVUri).getHost()) ? gdcHost + webDAVUri : webDAVUri; |
|
Maybe we should use HttpClient's |
|
I would go for UriBuilder, thanks ! |
|
well it seems UriBuilder can't bring anything useful, however here is the solution handling slahes corectly + test |
| initJadler(); | ||
|
|
||
| gdcService = mock(GdcService.class); | ||
| storeService = new DataStoreService(HttpClientBuilder.create(), gdcService, "http://localhost:"+port(), "user", "pass"); |
There was a problem hiding this comment.
probably the port should be passed as an argument?
There was a problem hiding this comment.
I would prefere not, the DataStoreService doesn't need to know about gdc uri structure, it only needs to know whole uri to prefix the uploads when needed. I will rename the contructor argument and create it more correctly
There was a problem hiding this comment.
DataStoreServiceTest changed to integration test (DataStoreServiceIT)
jimirocks
force-pushed
the
jmi-uploads
branch
4 times, most recently
from
734b64e
to
d7f29ab
Compare
|
one last thing: please write the commit message in the imperative mood |
jimirocks
force-pushed
the
jmi-uploads
branch
from
d7f29ab
to
e981ddb
Compare
jimirocks
changed the title
the link to uploads in Gdc, can be relative when the host is the same as gdcHost, added fallback to complete the relative path with gdcHost uri
jimirocks
force-pushed
the
jmi-uploads
branch
from
e981ddb
to
1a61655
Compare
jimirocks
changed the title
|
commit message is now in the imperative mood |
add support for relative upload paths in DataStoreService
No description provided.