Introduce Warehouse and Dataload Processes API support #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please rename ads to warehouse |
|
|
||
| @Override | ||
| protected boolean isFinished(ClientHttpResponse response) throws IOException { | ||
| return HttpStatus.CREATED.equals(response.getStatusCode()); |
There was a problem hiding this comment.
add check the instance is enabled
jimirocks
changed the title
jimirocks
changed the title
jimirocks
force-pushed
the
jmi-ads
branch
2 times, most recently
from
2938ffb
to
991bb0c
Compare
| * @param project project to which the process belongs | ||
| * @return created process | ||
| */ | ||
| public Process createProcess(Process process, File processData, Project project) { |
There was a problem hiding this comment.
project should be the first argument
| */ | ||
| public ProcessService(RestTemplate restTemplate, AccountService accountService) { | ||
| super(restTemplate); | ||
| this.accountService = accountService; |
| @Override | ||
| protected void onFinish() { | ||
| if (!getResult().isEnabled()) { | ||
| throw new GoodDataException("Created warehouse is not enabled!"); |
There was a problem hiding this comment.
please add ware house uri to the message
martiner
changed the title
martiner
pushed a commit
that referenced
this pull request
Sep 4, 2014
Introduce Warehouse and Dataload Processes API support
This was referenced Nov 8, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.