Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RELATED: BB-1690 Support measure value filters in UI SDK #365

Merged
merged 1 commit into from
Sep 16, 2019
Merged

RELATED: BB-1690 Support measure value filters in UI SDK #365

merged 1 commit into from
Sep 16, 2019

Conversation

qduval
Copy link
Contributor

@qduval qduval commented Sep 12, 2019

PR checklist

  • Change was tested using dev-release in Analytical Designer and Dashboards (if applicable).
  • Change is described in CHANGELOG.md.
  • Migration guide (for major update) is written to CHANGELOG.md.

@qduval qduval added do not merge Do not merge this yet release deps PR contains dev dependecies which must be released publicly first labels Sep 12, 2019
@gdgate
Copy link
Contributor

gdgate commented Sep 12, 2019

Build succeeded (check pipeline).

@gdgate
Copy link
Contributor

gdgate commented Sep 13, 2019

Build succeeded (check pipeline).

@gdgate
Copy link
Contributor

gdgate commented Sep 13, 2019

Build succeeded (check pipeline).

strouhaljan
strouhaljan suggested changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@strouhaljan strouhaljan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change.

src/DataLayer/converters/FilterConverter.ts Outdated Show resolved Hide resolved
@qduval qduval removed the release deps PR contains dev dependecies which must be released publicly first label Sep 16, 2019
@gdgate
Copy link
Contributor

gdgate commented Sep 16, 2019

Build succeeded (check pipeline).

strouhaljan
strouhaljan approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@strouhaljan strouhaljan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdgate
Copy link
Contributor

gdgate commented Sep 16, 2019

Build failed (check pipeline).

strouhaljan
strouhaljan reviewed Sep 16, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -11,6 +11,11 @@ The REST API versions in the table are just for your information as the values a
|\>= 10.0.0|3
|<= 9.0.1|2

<a name="11.18.3"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release these changes as minor, not patch.

@gdgate
Copy link
Contributor

gdgate commented Sep 16, 2019

Build failed (check pipeline).

@qduval qduval added merge and removed do not merge Do not merge this yet labels Sep 16, 2019
@gdgate gdgate removed the merge label Sep 16, 2019
@gdgate
Copy link
Contributor

gdgate commented Sep 16, 2019

Build failed (gate pipeline).

@qduval qduval added the do not merge Do not merge this yet label Sep 16, 2019
@qduval
Copy link
Contributor Author

qduval commented Sep 16, 2019

ok to test

@gdgate
Copy link
Contributor

gdgate commented Sep 16, 2019

Build succeeded (check pipeline).

strouhaljan
strouhaljan approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@strouhaljan strouhaljan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

strouhaljan
strouhaljan approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@strouhaljan strouhaljan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strouhaljan strouhaljan added merge and removed do not merge Do not merge this yet labels Sep 16, 2019
@gdgate
Copy link
Contributor

gdgate commented Sep 16, 2019

Build in pipeline check aborted.

@gdgate gdgate removed the merge label Sep 16, 2019
@gdgate gdgate merged commit 25512ea into gooddata:master Sep 16, 2019
@gdgate
Copy link
Contributor

gdgate commented Sep 16, 2019

Build succeeded (gate pipeline).

@qduval qduval deleted the qdu-bb-1690 branch September 16, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strouhaljan strouhaljan strouhaljan approved these changes

@martinmosko martinmosko Awaiting requested review from martinmosko

@petrjanu petrjanu Awaiting requested review from petrjanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qduval @gdgate @strouhaljan