Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: SD-769 save/load geo pushpin #394

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

lvkhanh
Copy link
Contributor

@lvkhanh lvkhanh commented Mar 8, 2020


Proposed release type: major|minor|patch (see points 6. - 8. of the semver spec)

PR checklist

  • Change was tested using dev-release in Analytical Designer and Dashboards (if applicable).
  • Change is described in CHANGELOG.md.
  • Migration guide (for major update) is written to CHANGELOG.md.
  • The proposed release type is appropriate (see the comment in PR template)

@lvkhanh lvkhanh added the ready to review PR is ready to final code review label Mar 8, 2020
@lvkhanh lvkhanh requested a review from no23reason as a code owner March 8, 2020 14:07
@gdgate
Copy link
Contributor

gdgate commented Mar 8, 2020

@lvkhanh lvkhanh changed the title wFEATURE: SD-769 save/load geo pushpin FEATURE: SD-769 save/load geo pushpin Mar 9, 2020
@ptquang86
Copy link

LGTM

@gdgate
Copy link
Contributor

gdgate commented Mar 9, 2020

@naibinh
Copy link
Contributor

naibinh commented Mar 9, 2020

LGTM

@gdgate
Copy link
Contributor

gdgate commented Mar 9, 2020

@gdgate
Copy link
Contributor

gdgate commented Mar 10, 2020

@naibinh naibinh self-requested a review March 10, 2020 03:31
@naibinh naibinh added merge and removed ready to review PR is ready to final code review labels Mar 10, 2020
@gdgate gdgate removed the merge label Mar 10, 2020
@gdgate gdgate merged commit 8e03ecc into gooddata:master Mar 10, 2020
@gdgate
Copy link
Contributor

gdgate commented Mar 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants