Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you create an entry with an ILIDefinition, but ill.id='' you lose the definition #166

Closed
fcbond opened this issue May 23, 2022 · 2 comments
Labels
wontfix This will not be worked on

Comments

@fcbond
Copy link
Collaborator

fcbond commented May 23, 2022

In the Japanese wordnet we have some entries where we have created an ILIDefinition, but are still not ready to propose them.

<Synset id="wnja-80002360-n" partOfSpeech="n" ili="">
      <Definition>ヒノキの木材</Definition>
      <ILIDefinition>wood of Japanese cypress</ILIDefinition>

In this case, wn loses the ILI definition (as it is defined for an ILI and there is no ILI).

Not sure what is the best thing to do here. If I make up an ili_id , then I can manipulate the definition, but it will surely cause problems later, ...

@goodmami
Copy link
Owner

Why not make these synset definitions with language attributes?

<Synset id="wnja-80002360-n" partOfSpeech="n" ili="">
      <Definition>ヒノキの木材</Definition>
      <Definition language="en">wood of Japanese cypress</Definition>

I'm also somewhat opposed to the idea of ILI-definitions in lexicons in general (globalwordnet/schemas#43), especially now that Wn can load ILIs separately from lexicons.

@goodmami goodmami added the wontfix This will not be worked on label Sep 29, 2022
@goodmami
Copy link
Owner

The WN-LMF schema does not prevent nor otherwise forbid an <ILIDefinition> from appearing for any particular values or absence of the ili attribute, so in some sense I agree that there is a missing feature in Wn here, but the conventional usage is that ILIDefinition only appears when a new ILI is proposed (ili="in"). For established ILIs, the definitions should be in the ILI file, and it doesn't make sense to me to have an ILI definition when there is no ILI whatsoever.

In any case, I'm not going to fix this because it would require schema changes (thus forcing anyone who upgrades to rebuild their database) for a fairly obscure use case. I suggest you store these definitions elsewhere or use synset definitions as shown in my previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants