backbonify explore and explore-collection #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single array of product objects has been replaced with three backbone collections. In the dom we now also have three ul elements backed by three products-list components. Instead of modifying the products array and rerendering when switching from e.g. popular to nearby we now hide popular and show nearby. This not only means that we can cache the views to avoid unnecessary re-rendering, we also replaced a single object of mutable state with three objects which are semantically static. The backbone collections also provide a much better platform for events. The framework of the explore page (i.e. the header), now only renders once on initialize instead of rerendering every time the products change. The products-list component will now listen to events on its collection instead of waiting for its owner to manually call render. The products-list will also now append views to the dom when models are added to its collection, as opposed to rerendeing them all every time as it does now. The search and pagination haven't been updated yet, but they should be working again soon.
|
…ons are now defaults.
|
couple more things. |
|
| @@ -125,7 +125,7 @@ | |||
| } | |||
|
|
|||
| , app = { | |||
| init: function(){ | |||
| init: utils.partial(require, ['./models/sync'], function(){ | |||
There was a problem hiding this comment.
I'm particularly proud of this one.
|
try this:
|
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change explore-page and explore-collection-page to use backbone collections.