Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode boundaries in GPT-4 #46

Closed
anatoleg opened this issue Apr 1, 2024 · 1 comment
Closed

Episode boundaries in GPT-4 #46

anatoleg opened this issue Apr 1, 2024 · 1 comment

Comments

@anatoleg
Copy link

anatoleg commented Apr 1, 2024

FormativeMemoryFactory.add_memories assumes that episodes are separated by '\n\n\n' using this code:
episodes = aggregated_result.split('\n\n\n') - line 216 in formative_memories,py
While defining agents in the three questions example, it complaints that the number of generated episodes does not match the number of formative ages.
I noticed that GPT-4 returns episodes separated by '\n\n' rather than '\n\n\n'.
Changing line 216 to use '\n\n' fixed the problem for me, but it may or may not work for other LLMs.

@jzleibo jzleibo closed this as completed Oct 6, 2024
@jzleibo jzleibo reopened this Oct 6, 2024
@jzleibo
Copy link
Collaborator

jzleibo commented Oct 6, 2024

Yes, that should work!, exactly

@jzleibo jzleibo closed this as completed Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants