Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document about environment variable escaping #492

Closed
whizsid opened this issue Mar 15, 2024 · 0 comments · Fixed by #496
Closed

Document about environment variable escaping #492

whizsid opened this issue Mar 15, 2024 · 0 comments · Fixed by #496
Labels
enhancement New feature or request

Comments

@whizsid
Copy link

whizsid commented Mar 15, 2024

TL;DR

I used this action to deploy an application which interacting with the Cloud SQL. I escaped the password by wrapping with double quotes. Then I got an error when connecting to SQL. I spent some time to debug it. Then I discovered that this action is using parseKVString from google action utilities and it is escaping characters using backslashes. We can avoid such problems by clearly documenting it.

Detailed design

No response

Additional information

No response
@whizsid whizsid added the enhancement New feature or request label Mar 15, 2024
@sethvargo sethvargo mentioned this issue Mar 28, 2024
Merged
sethvargo added a commit that referenced this issue Mar 28, 2024
@sethvargo
Use new helper to compile KV string (#496)
68504f3 
This requires changing the test inputs to expect JSON instead of K=V
pairs in our e2e runner.

- Fixes #495 
- Fixes #492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new helper to compile KV string google-github-actions/deploy-cloudrun
1 participant
@whizsid