-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
env vars with commas in value do not work #495
Comments
uses: 'google-github-actions/deploy-cloudrun@68504f3206b0ad0856bfeb602d0f7aca7a00e213'
with:
env_vars: |
KEY1=VALUE1
KEY2=VALUE2,VALUE3,VALUE4,VALUE5 Seems not fixed. Here is current output (notice the "ca1" was generated as a delimiter):
|
thansk @sethvargo - it does work with escaping the commas. However, there is a contradiction in my view below where you state:
I think as an aside that my example should work as-is. Unfortunately, if you don't fix this now then it will be a breaking change to fix in the future. |
Hi @brianzinn - sorry, I'm not following... You have to read the full context, not just the diff: https://github.com/google-github-actions/deploy-cloudrun?tab=readme-ov-file#inputs. Notably, the point about "You do not have to escape YAML or JSON." is under the
Thank you for the feedback. |
TL;DR
Unable to include environment variables with commas
Expected behavior
I was expecting the commas to be allowed. A delimiter would be introduced based on the input or otherwise we could supply one.
Observed behavior
The commas cause the environment to be split out - using parts of the values as keys for new entries.
Action YAML
Log output
Additional information
see #469 the environment values are being split out and new keys are being created from the values.
https://cloud.google.com/workflows/docs/use-environment-variables#set_multiple_environment_variables
That PR that was not merged I was suspecting would convert to:
gcloud run deploy ...
--set-env-vars ^@^KEY1=VALUE1,VALUE2,VALUE3@KEY2=VALUE2
So, if we were able to provide the delimiter as per the PR then it would be possible to have commas in the values? Otherwise if you are using a non-comma delimiter then you need to change how you are sending it...
I was unable to provide a full example since I have a lot of variables, so hopefully that makes a clean repro on your side.
The text was updated successfully, but these errors were encountered: