Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_ex in finish_dedup_wiki40b #35

Closed
wead-hsu opened this issue Nov 26, 2023 · 1 comment
Closed

remove_ex in finish_dedup_wiki40b #35

wead-hsu opened this issue Nov 26, 2023 · 1 comment

Comments

@wead-hsu
Copy link

Thanks for your excellent code.

I have successfully rerun the code in the repository about exactdedup. However, I have a problem about the following code:

159        remove_ex[i].append((max(int(remove[ptr][0] - byte_start - 6), 0),
160                              min(int(remove[ptr][1] - byte_start), byte_end-byte_start)))

I know the meaning of "6", but why not also subtract "6" in the right?

@carlini
Copy link
Collaborator

carlini commented Feb 24, 2024

We need to start 6 bytes off of the start (that's the left side) but the end is still the last byte; that doesn't need to change or be offset by 6 bytes.

@carlini carlini closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants