Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in imagenet_dataset.py? #57

Closed
vimalthilak opened this issue Oct 15, 2021 · 1 comment
Closed

Typo in imagenet_dataset.py? #57

vimalthilak opened this issue Oct 15, 2021 · 1 comment

Comments

@vimalthilak
Copy link

vimalthilak commented Oct 15, 2021 •
edited
Loading

I suspect builder.download_and_prepare() should be dataset_builder.download_and_prepare() in

scenic/scenic/dataset_lib/imagenet_dataset.py

Line 255 in 447a219

builder.download_and_prepare()

Please take a look and fix that typo if what I outlined above is correct
@MostafaDehghani MostafaDehghani mentioned this issue Oct 15, 2021
Merged
@MostafaDehghani
Copy link
Collaborator

Oh, thank you Vimal.
This line is automatically added when exporting the internal code to the GH repo and we missed this. This is just fixed in #58.

@vimalthilak vimalthilak mentioned this issue Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vimalthilak @MostafaDehghani