Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global entropy doesn't determine sampled values outside of [t0, t1] for BrownianTree #9

Closed
lxuechen opened this issue Aug 9, 2020 · 1 comment
Closed

Global entropy doesn't determine sampled values outside of [t0, t1] for BrownianTree #9

lxuechen opened this issue Aug 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@lxuechen
Copy link
Collaborator

lxuechen commented Aug 9, 2020

Following the note, the entropy argument passed to initialize BrownianTree doesn't govern the random numbers sampled outside the predetermined range [t0, t1].

Queries of this type is rate. Though, at the very least, there should be some warning or documentation on this.
@lxuechen lxuechen added the enhancement New feature or request label Aug 9, 2020
This was referenced Aug 17, 2020
Merged
Open
@patrick-kidger
Copy link
Collaborator

Closing as resolved in #28, as querying outside [t0, t1] is no longer possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lxuechen @patrick-kidger