Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XNLI Processor alignment issue #57

Closed
tonytan48 opened this issue Jan 7, 2021 · 2 comments
Closed

XNLI Processor alignment issue #57

tonytan48 opened this issue Jan 7, 2021 · 2 comments

Comments

@tonytan48
Copy link
Contributor

In the preprocessing script of XNLI: xtreme/third_party/processors/xnli.py. Line 42-43. The first line of xnli processor will be skipped. I noted that this processor is inherited from transformers processor class, this is useful for the raw XNLI 1.0 dataset, as it contains header. However, xtreme preprocessing script will first remove the original XNLI datasets' header: like premise,label,etc. For the preprocessed xnli dataset {split}-{lang} like dev-en.tsv, the first actual example will be skipped. Maybe the line 42-43 of xtreme/third_party/processors/xnli.py can be deleted as the preprocessing script already removed the header of XNLI.

@melvinjosej
Copy link
Collaborator

Thanks @tonytan48 for raising this. I checked this and you're right, we should be deleting L42-43 in .../processors/xnli.py . Can you please delete those two lines and send a PR? I'll approve it.

@tonytan48
Copy link
Contributor Author

Aight thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants