Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more formats in the Ogg container (e.g. Theora) #4970

Open
Yourbadman opened this issue Oct 17, 2018 · 4 comments
Open

Support more formats in the Ogg container (e.g. Theora) #4970

Yourbadman opened this issue Oct 17, 2018 · 4 comments

Comments

@Yourbadman
Copy link

movie.ogg.zip

Can't play this ogg file. OggExtrator.sniffInternal will return false, so none of the available extrators.

@Yourbadman
Copy link
Author

OggExtrator.java
if (!header.populate(input, true) || (header.type & 0x02) != 0x02) {
return false;
}
will be return false;

but i can play this ogg file in Android MediaPlayer.

@ojw28
Copy link
Contributor

ojw28 commented Oct 17, 2018

That's not what happens. It's returning false further down:

    if (FlacReader.verifyBitstreamType(resetPosition(scratch))) {
      streamReader = new FlacReader();
    } else if (VorbisReader.verifyBitstreamType(resetPosition(scratch))) {
      streamReader = new VorbisReader();
    } else if (OpusReader.verifyBitstreamType(resetPosition(scratch))) {
      streamReader = new OpusReader();
    } else {
      return false;                                              <---------- here
    }

This is because we only support Vorbis, Opus and Flac inside the OGG (see our supported formats page). Where-as I think this particular file contains Theora video. Marking as an enhancement, but I doubt this will considered high priority.

@ojw28 ojw28 self-assigned this Oct 17, 2018
@ojw28 ojw28 changed the title UnrecognizedInputFormatException: None of the available extractors Support more formats in the Ogg container (e.g. Theora) Oct 17, 2018
@lukwin91
Copy link

Hi, are there any chances to add Theora support?

@EchedelleLR
Copy link

I am also interested in Ogg Theora support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants