Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The --verbose mode is impractical #89

Closed
gendx opened this issue Mar 20, 2020 · 1 comment · Fixed by #87
Closed

The --verbose mode is impractical #89

gendx opened this issue Mar 20, 2020 · 1 comment · Fixed by #87
Assignees
Labels
bug Something isn't working

Comments

@gendx
Copy link
Collaborator

gendx commented Mar 20, 2020

Expected Behavior

OpenSK on an nRF52840-DK with the --verbose option enabled can be registered on https://webauthn.io/.

Actual Behavior

Currently, the --verbose option triggers many syscalls to write to the console. This slows down the whole app, making it impractical. For example, USB packets are dropped when trying to register on https://webauthn.io/ in --verbose mode on an nRF52840-DK, so registration fails altogether in this scenario.

Steps to Reproduce the Problem

  1. Flash OpenSK on a nRF52840-DK with --verbose enabled $ ./deploy.py --board nrf52840dk --opensk --panic-console --verbose.
  2. Visit https://webauthn.io/ and start the registration flow.
  3. Look at the console output and observe unexpected USB packets.
  4. Look at the webpage and observe that the registration flow hangs.

Specifications

@gendx gendx added blocked Depends on another pull-request or bugfix bug Something isn't working labels Mar 20, 2020
@gendx gendx mentioned this issue Apr 24, 2020
2 tasks
@gendx gendx removed the blocked Depends on another pull-request or bugfix label Jun 19, 2020
@gendx
Copy link
Collaborator Author

gendx commented Jun 19, 2020

Unblocking as tock/tock#1697 was fixed upstream. The fix pull request is in #87.

@gendx gendx closed this as completed in #87 Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant