-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google/vulkan-performance-layers requires a call to vkDeviceWaitIdle … #1028
Conversation
…or vkQueueWaitIdle. Since we want to be able to use that layer in conjunction with Amber we need to somehow communicate that the Amber script has completed.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…runtime-layer to know we need to signal the runtime layer.
@phoenixxxx This failed most of the builds. One of the error messages is:
Please take a look. |
…indeed not calling the right constructor.
Hi. @phoenixxxx we still need you to sign the CLA. Also, please rebase your changes on the main branch. |
I believe the email address you use needs to be your https://github.com/google/amber/pull/1028/checks?check_run_id=14485153716 |
Hi,
I had added my @google email address to my git account and made a different
commit with that email, which was accepted and merged.
Thanks,
-Serge
…On Wed, Aug 30, 2023 at 8:30 AM Steven Perron ***@***.***> wrote:
Hi. @phoenixxxx <https://github.com/phoenixxxx> we still need you to sign
the CLA. Also, please rebase your changes on the main branch.
I believe the email address you use needs to be your @google address for
the CLA to be automatically signed.
https://github.com/google/amber/pull/1028/checks?check_run_id=14485153716
—
Reply to this email directly, view it on GitHub
<#1028 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABV4TBRDDGKNQO6PZDNXPUTXX5MB3ANCNFSM6AAAAAAZIGQCLM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I think maybe this PR should be closed? |
…or vkQueueWaitIdle. Since we want to be able to use that layer in conjunction with Amber we need to somehow communicate that the Amber script has completed.