Fix cvd name after cvd version update.
#354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- After bumping `cvd` version in commit#497d7f09eb161cb095fb66b8be104f6bd75412de returned cvd names changed from `cvd-1` to `1`, which breaks compatibility with names used in `GET /devices` API.
jemoreira
requested changes
Aug 31, 2023
| @@ -156,7 +155,7 @@ func (a *CreateCVDAction) launchWithCanonicalConfig(op apiv1.Operation) (*apiv1. | |||
| if err := cmd.Run(); err != nil { | |||
| return nil, operator.NewInternalError(ErrMsgLaunchCVDFailed, err) | |||
| } | |||
| fleet, err := cvdFleet(a.execContext, a.paths.CVDBin()) | |||
| fleet, err := getCVDFleet(a.execContext, a.paths.CVDBin()) | |||
There was a problem hiding this comment.
cvdFleet was better: https://google.github.io/styleguide/go/decisions#getters
Comment on lines
+154
to
+160
| func decodeCVDName(name string) (string, string, error) { | ||
| parts := strings.SplitN(name, "-", 2) | ||
| if len(parts) != 2 { | ||
| return "", "", errors.New("invalid <GROUP>-<NAME> format") | ||
| } | ||
| return parts[0], parts[1], nil | ||
| } |
There was a problem hiding this comment.
Don't do this, the latest version of cvd already prints instance name, group name and webrtc device id separately.
There was a problem hiding this comment.
I see, I'll abandon this PR in favor of using webrtc device id: #355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cvdversion in commit#497d7f09eb161cb095fb66b8be104f6bd75412de returned cvd names changed fromcvd-1to1, which breaks compatibility with names used inGET /devicesAPI.