Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slightly worried we're not dealing with identify of codes carefully enough. can we make this function much more rigorous please? #2136

Closed
jingtang10 opened this issue Aug 16, 2023 · 0 comments · Fixed by #2148
Closed

slightly worried we're not dealing with identify of codes carefully enough. can we make this function much more rigorous please? #2136

jingtang10 opened this issue Aug 16, 2023 · 0 comments · Fixed by #2148
Labels
effort:small Small effort - 2 days P2 Medium priority issue

Comments

@jingtang10
Copy link
Collaborator 

          slightly worried we're not dealing with identify of codes carefully enough. can we make this function much more rigorous please?

for example, comparing two coding just by code but not by system doesn't meet the brief of returning "unique identifier".

Originally posted by @jingtang10 in #2065 (comment)
@santosh-pingle santosh-pingle added P2 Medium priority issue effort:small Small effort - 2 days labels Aug 21, 2023
@LZRS LZRS mentioned this issue Aug 29, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort:small Small effort - 2 days P2 Medium priority issue
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'system' in evaluation of unique Coding identifierString opensrp/android-fhir
2 participants
@jingtang10 @santosh-pingle