Emit Sync Job Finished Status After Sync Completion #1907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndegwamartin
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
kevinmost,
ktarasenko,
omarismail94,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
ndegwamartin
changed the title
omarismail94
previously approved these changes
Mar 17, 2023
There was a problem hiding this comment.
@ndegwamartin please update your PR with master! Ive approved it, but it needs to be up to date with master
|
@omarismail94 thank you |
aditya-07
requested changes
Mar 17, 2023
| @@ -116,6 +116,7 @@ internal class FhirSynchronizer( | |||
| } | |||
| } | |||
| return if (exceptions.isEmpty()) { | |||
| setSyncState(SyncJobStatus.Finished()) | |||
There was a problem hiding this comment.
SyncJobStatus.Finished signifies that the sync has completed/finished successfully and this change is setting it early irrespective of whether upload is successful or not.
That's why FhirSynchronizer.kt#L91 is the correct place to set the overall success status.
If we need the individual success status for upload and download, we can maybe think of adding new status values.
Noted |
|
Closing this for now |
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
May 11, 2023
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1964 - With unmerged PR google#1963 - With unmerged PR google#1907
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
May 23, 2023
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1964 - With unmerged PR google#1907
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 15, 2023
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1907 - With unmerged PR google#2016 - With unmerged PR google#2032
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 26, 2023
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1907 - With unmerged PR google#2016 - With unmerged PR google#2032 - With unmerged PR google#1669
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jun 26, 2023
- With unmerged PR #1 - With unmerged PR google#1917 - With unmerged PR google#1978 - With unmerged PR google#1907 - With unmerged PR google#2032 - With unmerged PR google#1669 - With unmerged PR google#2047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@jingtang10 @aditya-07 I think we should emit the Success status as well. Currently once its done downloading we don't notify dependent apps.
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.