Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable custom query running on FhirEngine #1

Closed
wants to merge 10 commits into from
Closed

Enable custom query running on FhirEngine #1

wants to merge 10 commits into from

Conversation

ekigamba
Copy link

  • Increment engine version to 0.1.0-alpha06-preview-p2p

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@ekigamba
Enable custom query running on FhirEngine
899e081 
- Increment engine version to 0.1.0-alpha06-preview-p2p
ndegwamartin added a commit that referenced this pull request Mar 21, 2023
@ndegwamartin
SDK Release: SDC, Engine, Workflow
8274e48 
- With unmerged PR #1
- With unmerged PR google#1669
- With unmerged PR google#1927
- With unmerged PR google#1917
allan-on added a commit that referenced this pull request Apr 14, 2023
@allan-on
SDK Release: Engine
d59c542 
  - With unmerged PR #1
  - With unmerged PR google#1917
allan-on added a commit that referenced this pull request Apr 17, 2023
@allan-on
SDK Release: SDC
3c2bc65 
  - With unmerged PR google#1973
  - With unmerged PR #1
  - With unmerged PR google#1917
allan-on added a commit that referenced this pull request Apr 26, 2023
@allan-on
SDK Release: Engine, SDC, Workflow, Contrib:Barcode
0d0cbf6 
  - With unmerged PR #1
  - With unmerged PR google#1917
  - With unmerged PR google#1978
  - With unmerged PR google#1964
allan-on added a commit that referenced this pull request Apr 26, 2023
@allan-on
SDK Release: Engine, SDC, Workflow, Contrib:Barcode, Common, Knowledger
9a5c079 
  - With unmerged PR #1
  - With unmerged PR google#1917
  - With unmerged PR google#1978
  - With unmerged PR google#1964
ndegwamartin added a commit that referenced this pull request May 11, 2023
@ndegwamartin
SDK Release: Engine, SDC, Workflow, Contrib:Barcode, Common, Knowledger
de945a5 
  - With unmerged PR #1
  - With unmerged PR google#1917
  - With unmerged PR google#1978
  - With unmerged PR google#1964
  - With unmerged PR google#1963
  - With unmerged PR google#1907
ndegwamartin added a commit that referenced this pull request May 23, 2023
@ndegwamartin
SDK Release: Engine, SDC, Workflow, Contrib:Barcode, Common, Knowledger
ffa535a 
  - With unmerged PR #1
  - With unmerged PR google#1917
  - With unmerged PR google#1978
  - With unmerged PR google#1964
  - With unmerged PR google#1907
ndegwamartin added a commit that referenced this pull request Jun 15, 2023
@ndegwamartin
SDK Release: Engine, SDC, Workflow, Contrib:Barcode, Common, Knowledger
6968bf1 
  - With unmerged PR #1
  - With unmerged PR google#1917
  - With unmerged PR google#1978
  - With unmerged PR google#1907
  - With unmerged PR google#2016
  - With unmerged PR google#2032
ndegwamartin added a commit that referenced this pull request Jun 26, 2023
@ndegwamartin
SDK Release: Engine, SDC, Workflow, Contrib:Barcode, Common, Knowledger
e87bf59 
      - With unmerged PR #1
      - With unmerged PR google#1917
      - With unmerged PR google#1978
      - With unmerged PR google#1907
      - With unmerged PR google#2016
      - With unmerged PR google#2032
      - With unmerged PR google#1669
ndegwamartin added a commit that referenced this pull request Jun 26, 2023
@ndegwamartin
SDK Release: Engine, SDC, Workflow, Contrib:Barcode, Common, Knowledger
92b1938 
   - With unmerged PR #1
   - With unmerged PR google#1917
   - With unmerged PR google#1978
   - With unmerged PR google#1907
   - With unmerged PR google#2032
   - With unmerged PR google#1669
   - With unmerged PR google#2047
@ndegwamartin ndegwamartin mentioned this pull request Aug 23, 2023
Closed
3 tasks
ndegwamartin added a commit that referenced this pull request Aug 23, 2023
@ndegwamartin
Engine, SDC, Workflow, Common, Knowledge
a6b0ec2 
- With unmerged PR google#2032
- With unmerged PR #1
- With unmerged PR google#1669
- With unmerged PR google#2132
- With unmerged PR #9
ndegwamartin added a commit that referenced this pull request Aug 23, 2023
@ndegwamartin
Engine, SDC, Workflow, Common, Knowledger
1c93f90 
- With unmerged PR google#2032
- With unmerged PR #1
- With unmerged PR google#1669
- With unmerged PR google#2132
ndegwamartin added a commit that referenced this pull request Aug 28, 2023
@ndegwamartin
Engine, SDC, Workflow, Common, Knowledge
75f243d 
    - With unmerged PR google#2032
    - With unmerged PR #1
    - With unmerged PR google#1669
    - With unmerged PR google#2132
    - With unmerged PR #9
    - With unmerged PR google#2076
    - With unmerged PR #10
ndegwamartin added a commit that referenced this pull request Sep 7, 2023
@ndegwamartin
Engine, SDC, Workflow, Common, Knowledge
f5280e9 
        - With unmerged PR google#2032
        - With unmerged PR #1
        - With unmerged PR google#1669
        - With unmerged PR google#2132
        - With unmerged PR #9
        - With unmerged PR google#2076
        - With unmerged PR #10
ndegwamartin added a commit that referenced this pull request Sep 7, 2023
@ndegwamartin
Engine, SDC, Workflow, Common, Knowledge
d7036a9 
        - With unmerged PR google#2032
        - With unmerged PR #1
        - With unmerged PR google#1669
        - With unmerged PR google#2132
        - With unmerged PR #9
        - With unmerged PR google#2076
        - With unmerged PR #10
ndegwamartin added a commit that referenced this pull request Sep 13, 2023
@ndegwamartin
Engine, SDC, Workflow, Common, Knowledge
314b479 
            - With unmerged PR #1
            - With unmerged PR google#1669
            - With unmerged PR #9
            - With unmerged PR google#2076
            - With unmerged PR #10
ndegwamartin added a commit that referenced this pull request Sep 13, 2023
@ndegwamartin
Engine, SDC, Workflow, Common, Knowledge
edb2842 
            - With unmerged PR #1
            - With unmerged PR google#1669
            - With unmerged PR #9
            - With unmerged PR #10
ndegwamartin added a commit that referenced this pull request Sep 18, 2023
@ndegwamartin
Engine, SDC, Workflow, Knowledge
80b2d69 
  - With unmerged PR #1
  - With unmerged PR google#1669
  - With unmerged PR google#2178
  - With unmerged PR #9
  - With unmerged PR #10
ndegwamartin added a commit that referenced this pull request Sep 18, 2023
@ndegwamartin
Engine, SDC, Workflow, Knowledge
283ad6e 
  - With unmerged PR #1
  - With unmerged PR google#1669
  - With unmerged PR google#2178
  - With unmerged PR #9
  - With unmerged PR #10
@ellykits
Copy link
Collaborator

Will close this. This is no longer needed. p2p implemented code was refactored to use the queries from the SDK as is, preliminary testing indicated some improvements.

@ellykits ellykits closed this Sep 19, 2023
@ndegwamartin ndegwamartin mentioned this pull request Sep 20, 2023
Closed
@ndegwamartin
Copy link

Will close this. This is no longer needed. p2p implemented code was refactored to use the queries from the SDK as is, preliminary testing indicated some improvements.

cc @Rkareko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegwamartin ndegwamartin ndegwamartin left review comments

@jingtang10 jingtang10 Awaiting requested review from jingtang10 jingtang10 will be requested when the pull request is marked ready for review jingtang10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ekigamba @ellykits @ndegwamartin @Rkareko