Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating initial values fix #2016

Merged
merged 8 commits into from
Jun 26, 2023
Merged

Conversation

maimoonak
Copy link
Collaborator

@maimoonak maimoonak commented May 29, 2023

Fixes #2019

Description
Code was wrongfully setting only first item as initial value for repeating questions with multiple items in list

Type
Choose one: Bug fix

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@maimoonak maimoonak requested review from a team and santosh-pingle as code owners May 29, 2023 10:54
@maimoonak maimoonak requested a review from aditya-07 May 29, 2023 10:54
@santosh-pingle
Copy link
Collaborator

@maimoonak
Please link the issue to the pr.

@maimoonak
Copy link
Collaborator Author

@maimoonak Please link the issue to the pr.

Done

Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! @maimoonak

…extensions/MoreQuestionnaireItemComponentsTest.kt

Co-authored-by: santosh-pingle <86107848+santosh-pingle@users.noreply.github.com>
Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run spotless apply, to pass the kokoro check.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @maimoonak please address santosh's comments also

ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Jun 15, 2023
  - With unmerged PR #1
  - With unmerged PR google#1917
  - With unmerged PR google#1978
  - With unmerged PR google#1907
  - With unmerged PR google#2016
  - With unmerged PR google#2032
@omarismail94 omarismail94 enabled auto-merge (squash) June 26, 2023 13:19
@omarismail94 omarismail94 dismissed jingtang10’s stale review June 26, 2023 13:19

All comments addressed

@omarismail94 omarismail94 merged commit dcdee27 into google:master Jun 26, 2023
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Jun 26, 2023
      - With unmerged PR #1
      - With unmerged PR google#1917
      - With unmerged PR google#1978
      - With unmerged PR google#1907
      - With unmerged PR google#2016
      - With unmerged PR google#2032
      - With unmerged PR google#1669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Multiple initial values for repeating question
4 participants