Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual sync is not triggered, issue #2492 #2507

Merged
merged 22 commits into from
May 1, 2024

Conversation

hoangchungk53qx1
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2492

Description
It should trigger the manual sync, and sync the patient.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix)

Screenshots (if applicable)

Checklist

  • ✔️ I have read and acknowledged the Code of conduct.
  • ✔️ I have read the Contributing page.
  • ✔️ I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • ✔️ I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • ✔️ I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • ✔️ I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • ✔️ I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MJ1998 MJ1998 merged commit 12d0762 into google:master May 1, 2024
4 checks passed
icrc-fdeniger pushed a commit to icrc-fdeniger/android-fhir that referenced this pull request May 9, 2024
* refactor demo project

* refactor demo project

* splitting the flow into 2 state

* Spotless

* fixed manual is not triggered

* fixed manual is not triggered

* spotless apply

---------

Co-authored-by: Jing Tang <jingtang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Clicking on "manual sync" does not initiate the one-time sync.
5 participants