Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on "manual sync" does not initiate the one-time sync. #2492

Closed
santosh-pingle opened this issue Mar 19, 2024 · 5 comments · Fixed by #2507
Closed

Clicking on "manual sync" does not initiate the one-time sync. #2492

santosh-pingle opened this issue Mar 19, 2024 · 5 comments · Fixed by #2507
Labels
effort:small Small effort - 2 days P2 Medium priority issue

Comments

@santosh-pingle
Copy link
Collaborator

Describe the bug
Clicking on manual sync does not trigger the one time sync.

Component
reference app,

To Reproduce
Steps to reproduce the behavior:

  1. Open demo app
  2. Create new patient
  3. Click on manual sync
  4. See, manual is not triggered

Expected behavior
It should trigger the manual sync, and sync the patient.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Pixel2a emulator
  • Android version: 12

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.
@santosh-pingle
Copy link
Collaborator Author

This might have caused the issue #2348

@aditya-07 aditya-07 added P2 Medium priority issue effort:small Small effort - 2 days labels Mar 20, 2024
@santosh-pingle
Copy link
Collaborator Author

@@hoangchungk53qx1 can you please take look at it?

@hoangchungk53qx1
Copy link
Contributor

@@hoangchungk53qx1 can you please take look at it?

i'll check it again tomorrow

@hoangchungk53qx1
Copy link
Contributor

i just checked, everything is still working
Let me try again with your device

@hoangchungk53qx1 hoangchungk53qx1 mentioned this issue Apr 3, 2024
Merged
@hoangchungk53qx1
Copy link
Contributor

hoangchungk53qx1 commented Apr 3, 2024 •
edited

@santosh-pingle i see it, i created MR (#2507)

MJ1998 pushed a commit that referenced this issue May 1, 2024
@hoangchungk53qx1 @jingtang10
Fix manual sync is not triggered, issue #2492 (#2507)
12d0762 
* refactor demo project

* refactor demo project

* splitting the flow into 2 state

* Spotless

* fixed manual is not triggered

* fixed manual is not triggered

* spotless apply

---------

Co-authored-by: Jing Tang <jingtang@google.com>
icrc-fdeniger pushed a commit to icrc-fdeniger/android-fhir that referenced this issue May 9, 2024
@hoangchungk53qx1 @jingtang10 @icrc-fdeniger
Fix manual sync is not triggered, issue google#2492 (google#2507)
52238d2 
* refactor demo project

* refactor demo project

* splitting the flow into 2 state

* Spotless

* fixed manual is not triggered

* fixed manual is not triggered

* spotless apply

---------

Co-authored-by: Jing Tang <jingtang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort:small Small effort - 2 days P2 Medium priority issue
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix manual sync is not triggered, issue #2492 hoangchungk53qx1/android-fhir
3 participants
@aditya-07 @hoangchungk53qx1 @santosh-pingle