-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uploads for non-seekable streams #19
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
I signed it! |
Or at least our company did "Improbable Worlds Ltd" |
this looks good -- just want to ask @thobrla to confirm that this is unlikely to quietly break anything for gsutil? |
Looks good. Note: we use seekable() elsewhere but that only applies to IOBase objects, which is not applicable for upload streams with type 'file'. |
awesome -- thanks @mwitkow-io! |
Fix uploads for non-seekable streams
Fixes #18