Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploads for non-seekable streams #19

Merged
merged 1 commit into from
Apr 16, 2015

Conversation

mwitkow
Copy link
Contributor

@mwitkow mwitkow commented Apr 16, 2015

Fixes #18

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.97% when pulling 4569fa5 on mwitkow-io:fix_upload_from_streamable into f92dfb0 on google:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.97% when pulling 4569fa5 on mwitkow-io:fix_upload_from_streamable into f92dfb0 on google:master.

@mwitkow
Copy link
Contributor Author

mwitkow commented Apr 16, 2015

I signed it!

@mwitkow
Copy link
Contributor Author

mwitkow commented Apr 16, 2015

Or at least our company did "Improbable Worlds Ltd"

@craigcitro
Copy link
Contributor

this looks good -- just want to ask @thobrla to confirm that this is unlikely to quietly break anything for gsutil?

@thobrla
Copy link
Contributor

thobrla commented Apr 16, 2015

Looks good.

Note: we use seekable() elsewhere but that only applies to IOBase objects, which is not applicable for upload streams with type 'file'.

@craigcitro
Copy link
Contributor

awesome -- thanks @mwitkow-io!

craigcitro added a commit that referenced this pull request Apr 16, 2015
@craigcitro craigcitro merged commit 2178dfb into google:master Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload.__StreamMedia breaks on non-seekable streams
5 participants