Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_unique should be an associated function #88

Closed
adetaylor opened this issue Nov 12, 2020 · 0 comments · Fixed by #96
Closed

make_unique should be an associated function #88

adetaylor opened this issue Nov 12, 2020 · 0 comments · Fixed by #96

Comments

@adetaylor
Copy link
Collaborator

Right now, for a type called (e.g.) Bob, we generate a function called fn Bob_make_unique() -> UniquePtr<Bob>. It would be nicer if we can make that an associated function on the Bob type. This probably requires dtolnay/cxx#464 (or, of course, we do dtolnay/cxx#280 to add constructor support directly into cxx and remove it from autocxx).

This was referenced Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant