feat: add connection previewers #7825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add connection previewer interface * chore: PR comments
* feat: add connection highlighter interface * fix: remove unnecessary method from the path object interface
* chore: move connection highlighting into the geras renderer * chore: remove IConnectionHighlighter interface * chore: format * chore: fixup * chore: format * fix: PR comments
* feat: add connection highlighting to zelos * fix: drawing outputs * chore: cleanup
* chore: add noop InsertionMarkerPreviewer * feat: add previewing replacements * feat: add previewing insertions * feat: add highlighting of connections to previewer * fix: disabling events in the connection previewer * chore: fixup docs * chore: typo
* chore: reorganize drag logic * chore: implement would delete block logic * fix: just use snap radius. Turns out the numbers are the same. * chore: add connection previewing * fix: applying connections * chore: remove dragged connection manager from block dragger * fix: deleting blocks
…ving (#7795) * fix: remove zelos highlight override * feat: add isHighlighted to rendered connection * feat: add refreshing connection highlighting * chore: remove highlight and unhighlight connection APIs * chore: PR comments
BeksOmega
force-pushed
the
connection-previewers
branch
from
ae1b834
to
1d49ecb
Compare
maribethb
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
LGTM on the basis everything has already been reviewed. If you want me to give it a deeper look, let me know
I'd still use conventional commit for the PR title though, because our release notes use PR titles, not commit titles, and you want the action to tag this PR correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Most of #7204 (just needs fixes in samples)
Proposed Changes + Reasons
Adds connection previewers so that external devs can swap out how connections are previewed or add extra behavior to previewing connections (e.g. the dynamic connection plugin, or reindeer connections).
Test Coverage
Manually tested.
Documentation
Docs is on my task list.
Additional Information
Everything has already been reviewed. This will be rebase-and-merge-ed into develop, which is why the PR title doesn't follow conventional commits.