Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump to json fails if mj model contains no meshes #461

Closed
Nate711 opened this issue Feb 23, 2024 · 2 comments
Closed

Dump to json fails if mj model contains no meshes #461

Nate711 opened this issue Feb 23, 2024 · 2 comments
Assignees

Comments

@Nate711
Copy link

Nate711 commented Feb 23, 2024

I had a case where my mujoco model had only geometry (boxes, spheres, etc) and no meshes. When I tried to use the HTML visualizer with this model (HTML(html.render(brax_sys, rollout))), I got an error in the json dumper because mj_mode.nmeshes returned 0 and this value was not correctly handled.

vert, face = _get_mesh(sys.mj_model, sys.geom_dataid[id_])

@btaba btaba self-assigned this Feb 27, 2024
@btaba
Copy link
Collaborator

btaba commented Feb 27, 2024

Thanks for the bug report! We'll send out a fix shortly

@btaba
Copy link
Collaborator

btaba commented Feb 28, 2024

This should be fixed in 0825bcb , please let us know if that doesn't work! Closing for now

@btaba btaba closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants