Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spec for conversion of uninitialized Value proto to null. #119

Open
JimLarson opened this issue May 5, 2020 · 1 comment
Open

Update spec for conversion of uninitialized Value proto to null. #119

JimLarson opened this issue May 5, 2020 · 1 comment
Assignees
@JimLarson
Labels
enhancement

Comments

@JimLarson
Copy link
Contributor

The google.protobuf.Value proto is more useful if its default value has a meaningful CEL value. Converting it to null matches the spirit of the various *Value wrapper types, as well as the spirit of null itself.
@JimLarson JimLarson self-assigned this May 5, 2020
@JimLarson
Copy link
Contributor Author

Note that this creates an ambiguity in reading an unset field vs one set to null. This can be semantically significant, as the Value proto definition says "absence of any variant indicates an error". However, the ambiguity can be resolved by testing with has().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JimLarson JimLarson

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JimLarson and others