Carriage returns undo and redo one at a time

[aaxu]

Do you think it'll be better if we undo and redo new lines the same way we do mouse actions? That is, we return a new line character if we see one after a redo. However, we only redo 2 different types of actions at a time, so if the redo chain was something like (insert, mouse, newLines), we would only undo the newLines (until there are no more left), then the mouse action.

[dschuyler]

I agree that that what get's done or undone as a unit could be improved. This is an area where it seems to help to try out ideas. I.e. I'd suggest trying a change for a bit to see if you like it. I've done that a couple times and found that some idea I had caused other consequences I didn't like. That's not a critique of your suggestion. I think it sounds like a good idea, but I can't be sure until trying it for awhile. Does that make sense?

[dschuyler]

If you want to make a PR, I'm happy to pull it in locally and try it out :)

[aaxu]

Oh yeah for sure! I'll work on it. The current thing is that right now, carriage returns are always followed by a cursor move, so some if statements are never actually used and carriage returns are also never combined. I'm gonna try and clean this up a bit.

One question: Is there a particular reason why the redoAddChange for carriage returns is a tuple of 1 element?

[dschuyler]

This seems good to me. I've been running with the patch (PR) for awhile.

On the carriage returns tuple. IIRC, it's just that was one of the first things I did when I started writing the editor. I think I was making all redo records hold a tuple. I.e. there's a reason, but not necessarily a good reason. :)

[dschuyler]

Oh and is this enhancement ready to be closed?

[aaxu]

Yeah I think it's finished so close away!

Edit: oh I can close it too LOL