Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always getting Duplicate parameter name "_". Can not disable es5Strict check / warning. #3225

Closed
DanielRuf opened this issue Feb 5, 2019 · 1 comment
Labels
internal-issue-created An internal Google issue has been created to track this GitHub issue triage-done Has been reviewed by someone on triage rotation.

Comments

@DanielRuf
Copy link

java -jar compiler.jar --jscomp_warning=es5Strict --language_in=ECMASCRIPT5 --language_out=ECMASCRIPT5 -O=WHITESPACE_ONLY --js_output_file=1549035730_99ceadf4011cf132f381b55c6b2c28df.js.min 1549035730_99ceadf4011cf132f381b55c6b2c28df.js
1549035730_99ceadf4011cf132f381b55c6b2c28df.js:744: ERROR - Parse error. Duplicate parameter name "_"
$.subscribe('plugin/swAddArticle/onAddArticle',cartRefresh);$.subscribe('plugin/swCollapseCart/onRemoveArticleFinished',cartRefresh);});})(jQuery,window);;(function($,window){'use strict';$.plugin('swInvalidTosJump',{defaults:{jumpLabelSelector:'label[for="sAGB"]',errorClass:'has--error'},init:function(){var me=this;me.$jumpLabel=$(me.opts.jumpLabelSelector);me._on(me.$el,'invalid',$.proxy(me.jumpToInvalid,me));},jumpToInvalid:function(){var me=this;window.scroll(0,me.$el.offset().top-(window.innerHeight/2));me.$jumpLabel.addClass(me.opts.errorClass);}});})(jQuery,window);$.subscribe('plugin/swLastSeenProducts/onCreateProductImage',function(_,_,element,data){if(data.images[0].sourceSetWebP){var imageElement=element.find('.image--element');var content=imageElement.find('.image--media').html();var webPTag='<source srcset="'+data.images[0].sourceSetWebP+'" data-srcset="'+data.images[0].sourceSetWebP+'" type="image/webp">';content='<picture>'+webPTag+content+'</picture>';imageElement.html(content);}});;(function($,window){'use strict';var $body=$('body'),$html=$('html'),isTouchIE=$html.hasClass('is--ie-touch');$.plugin('advancedMenu',{defaults:{'listSelector':'.navigation--list.container','navigationItemSelector':'.navigation--entry:not(.is--home)','navigationLinkSelector':'.navigation--link','closeButtonSelector':'.button--close','menuContainerSelector':'.menu--container','menuActiveClass':'menu--is-active','itemHoverClass':'is--hovered','hoverDelay':0},init:function(){var me=this;me.applyDataAttributes();me._$list=$(me.opts.listSelector);if(!me._$list.length){return;}
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        ^

1 error(s), 0 warning(s)
@blickly
Copy link
Contributor

blickly commented Feb 6, 2019

I thought that we required code to be "use strict" compatible, but that doesn't appear to be the case according to https://github.com/google/closure-compiler/wiki/Compiler-Assumptions

Created internal issue b/123959375

@blickly blickly added triage-done Has been reviewed by someone on triage rotation. internal-issue-created An internal Google issue has been created to track this GitHub issue labels Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-issue-created An internal Google issue has been created to track this GitHub issue triage-done Has been reviewed by someone on triage rotation.
Projects
None yet
Development

No branches or pull requests

2 participants