Skip to content

Commit

Permalink
Eliminates prototypal inheritance errors related to class-side inheri…
Browse files Browse the repository at this point in the history
…tance.

This CL is a preparatory step to prevent build errors and test failures for an upcoming change to typecheck prototypal inheritance of classes. The goal is to unblock progress by the JS Infrastructure team with the smallest possible overhead.

This is the list of errors used to generate this Rosie: https://docs.google.com/spreadsheets/d/1a9QMRl6hGfQ03tfH0-CWGKLVJTB050-V4-ATTjisuTo/edit#gid=758793470 It may go out of date, but should contain any errors in these files. To confirm your fixes please patch CL/215669793 and build the affected targets. It's probably wise to build from head as well ("--define JSC_AT_HEAD=true").

This is the list of errors used to generate this Rosie: https://docs.google.com/spreadsheets/d/1a9QMRl6hGfQ03tfH0-CWGKLVJTB050-V4-ATTjisuTo/edit#gid=758793470 It may go out of date, but should contain any errors in these files. To confirm your fixes please patch CL/215669793 and build the affected targets. It's probably wise to build from head as well ("--define JSC_AT_HEAD=true").

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=225935227
  • Loading branch information
nreid260 committed Dec 19, 2018
1 parent e0d08a3 commit 43c6326
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions closure/goog/testing/jstdtestcaseadapter.js
Expand Up @@ -38,6 +38,7 @@ goog.require('goog.testing.jsunit');
* JSTD testing queue.
* @return {!Function}
* @private
* @suppress {checkPrototypalTypes}
*/
goog.testing.JsTdTestCaseAdapter.TestCaseFactory_ = function(
testCaseName, condition, opt_proto, opt_isAsync) {
Expand Down

0 comments on commit 43c6326

Please sign in to comment.