Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint failure should not result in invalid .city file being created #114

Closed
cpcallen opened this issue Oct 3, 2017 · 0 comments
Closed

Checkpoint failure should not result in invalid .city file being created #114

cpcallen opened this issue Oct 3, 2017 · 0 comments
Labels
bug

Comments

@cpcallen
Copy link
Collaborator

cpcallen commented Oct 3, 2017

At the moment, if a checkpoint fails part way through writing the .city file to disk (e.g., because of disk full) it will leave an invalid but validly-named .city file in the checkpoint directory.

  • The .city file should be created atomically (i.e., by renaming a .city.partial file or similar).
  • Failed attempts to write this file should clean up after themselves.
@cpcallen cpcallen added the bug label Oct 3, 2017
cpcallen added a commit that referenced this issue Oct 4, 2017
@cpcallen
Make checkpointing more robust
7a6b482 
- Create .world file atomically (by renaming .world.partial).
- Don't crash if writing fails.
- Attempt to unlink .partial file so failed writes/moves don't leave
cruft lying around.
- Log confirmation of successful checkpoint, or short error message on
failure.

Fixes #114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cpcallen