-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new ahu type #1003
base: master
Are you sure you want to change the base?
added new ahu type #1003
Conversation
- CONTROL | ||
|
||
SFPC: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead use a combination of SSPM
and SFC
, along with maybe SFSS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can if i add the rotational and linear velocity fields onto one of the suggested types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment below.
- OPERATIONAL | ||
|
||
EFPC: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead use ED
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use ED if i set the damper command as missing and then add the supply_fan_run_command
supply_air_linearvelocity_sensor
supply_fan_rotationalvelocity_sensor
somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevin-hereworks yes please use ED
- Use
supply_fan_run_command
by replacingSS
withSFSS
- Use existing field
supply_air_flowrate_sensor
and deletesupply_air_linearvelocity_sensor
- Add
supply_fan_rotationalvelocity_sensor
as optional onSFVSC
(and make certain fields on that type missing, if needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay and then can the fire and smoke alarms be added to the sfss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest excluding the fire and smoke alarms from this type. Typically, we see those fields modeled as part of a SAFETY system.
Additionally, there is no need for this new type EFPC
at all (now that you are using ED
- OPERATIONAL | ||
|
||
ESDC: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a combination of EDM
and SDM
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, changed
description: "fire and smoke alarm monitoring." | ||
is_abstract: true | ||
uses: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add as optional on SS
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
fixed_min: 0.0 | ||
flexible_max: 25.4000508 | ||
|
||
- exhaust_fan_rotationalvelocity_sensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unusual to see rotationalvelocity
sensors. Are there more common measures like speed_percentage
or speed_frequency
that are available in your system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rotational velocity was used because the units on the reporting field are rpm, is this okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OK to use rotationalvelocity
if there are no speed_percentage
or speed_frequency
fields available in the system.
@@ -3116,3 +3116,16 @@ literals: | |||
- ultraviolet_irradiance_sensor: | |||
fixed_min: 0.0 | |||
flexible_max: 2000.0 | |||
|
|||
- supply_air_linearvelocity_sensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this being measured in liters per second (or some other flowrate
unit)? If so, you can use the existing field supply_air_flowrate_sensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its in meters per second unfortunately, we also have supply_air_flowrate_sensor
on this device though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using supply_air_flowrate_sensor
and omitting the linear velocity sensor completely (as they are functionally redundant and the flowrate sensor is more useful for downstream applications)
fixed_min: 0.0 | ||
flexible_max: 25.4000508 | ||
|
||
- exhaust_fan_rotationalvelocity_sensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OK to use rotationalvelocity
if there are no speed_percentage
or speed_frequency
fields available in the system.
is_canonical: true | ||
implements: | ||
- AHU | ||
- SS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use SFSS here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use SFSS
and remove SS
is_canonical: true | ||
implements: | ||
- AHU | ||
- SS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use SFSS here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove SS
and use SFSS
- OPERATIONAL | ||
|
||
EFPC: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevin-hereworks yes please use ED
- Use
supply_fan_run_command
by replacingSS
withSFSS
- Use existing field
supply_air_flowrate_sensor
and deletesupply_air_linearvelocity_sensor
- Add
supply_fan_rotationalvelocity_sensor
as optional onSFVSC
(and make certain fields on that type missing, if needed)
- CONTROL | ||
|
||
SFPC: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment below.
- RMM | ||
- RTM | ||
- FDPM | ||
- EFPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this to use ED
(and remove EFPC
completely)
is_canonical: true | ||
implements: | ||
- AHU | ||
- SS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use SFSS
and remove SS
is_canonical: true | ||
implements: | ||
- AHU | ||
- SS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove SS
and use SFSS
@@ -3116,3 +3116,16 @@ literals: | |||
- ultraviolet_irradiance_sensor: | |||
fixed_min: 0.0 | |||
flexible_max: 2000.0 | |||
|
|||
- supply_air_linearvelocity_sensor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using supply_air_flowrate_sensor
and omitting the linear velocity sensor completely (as they are functionally redundant and the flowrate sensor is more useful for downstream applications)
- SFC | ||
- HWRC | ||
- ESDC | ||
- FSAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is FSAM
? I do not see this defined in the ABSTRACT file
- SSPM | ||
- SFC | ||
- HWRC | ||
- ESDC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is ESDC
? I do not see this defined in the ABSTRACT file
@@ -4100,7 +4116,22 @@ AHU_CHWSC_HWSC_ECON_EDBPC_RFSS2X_RFVSC2X_SFSS2X_SFVSC2X_SSPC: | |||
- SFVSC2X | |||
- SSPC | |||
|
|||
|
|||
AHU_SS_SFSS_RMM_STM_FDPM_SSPM_SFC_HWRC_EDM_SDM_FSAM_SFVSC_EFVSC: | |||
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms supply and exhaust rotational velocity sensors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You note that this AHU has cooling but I don't see any cooling ABSTRACT types (e.g., CHWSC, DXSC, etc.)
- RTM | ||
- FDPM | ||
- EFPC | ||
- SFPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is SFPC
? I don't see it defined in the ABSTRACT file
@@ -4069,6 +4069,22 @@ AHU_SFSS_SFMSC_SFVSC_FDPM_CHWSC_RTM_RACO2C_SSPC2X_VOADM2X_SAIDC2X_RAIDC2X_SSPC: | |||
- RAIDC2X | |||
- SSPC | |||
|
|||
|
|||
AHU_SS_RMM_RTM_FDPM_EFPC_SFPC_HWSC_ESDC_FSAM: | |||
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You note that this unit has cooling, but there are not any cooling ABSTRACT types applied.
No description provided.