Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new ahu type #1003

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

added new ahu type #1003

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
75c68de
added new ahu type
kevin-hereworks Apr 5, 2023
52f6911
fixed typpo
kevin-hereworks Apr 5, 2023
87bfe45
fixed typpo
kevin-hereworks Apr 5, 2023
06e457c
fixed typo
kevin-hereworks Apr 5, 2023
79315fe
added optional fileds
kevin-hereworks Apr 5, 2023
031b773
added missing filed
kevin-hereworks Apr 5, 2023
0e0a80a
added second, similar ahu
kevin-hereworks Apr 5, 2023
a0e8792
typo
kevin-hereworks Apr 5, 2023
63a438f
Merge branch 'master' into new-ahu-type
charbull Apr 10, 2023
7ff1408
Merge branch 'master' into new-ahu-type
cstirdivant Jun 14, 2023
05bc8ad
Merge branch 'master' into new-ahu-type
cstirdivant Jun 21, 2023
50067c9
removed esdc type, moved smoke and fire alarm to ss
kevin-hereworks Jul 25, 2023
1fae0a3
eol
kevin-hereworks Jul 25, 2023
ec53b92
using ED, EFVSC, SFVSC
kevin-hereworks Jul 25, 2023
35592d9
Merge branch 'master' into new-ahu-type
cstirdivant Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 49 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6618,3 +6618,52 @@ VMADC:
- mixed_air_damper_percentage_sensor
implements:
- CONTROL

SFPC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead use a combination of SSPM and SFC, along with maybe SFSS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can if i add the rotational and linear velocity fields onto one of the suggested types?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment below.

description: "supply pressure monitoring, flow control."
is_abstract: true
opt_uses:
- supply_fan_run_command
- supply_air_linearvelocity_sensor
- supply_fan_rotationalvelocity_sensor
uses:
- supply_air_static_pressure_sensor
- supply_air_flowrate_sensor
- supply_air_flowrate_setpoint
implements:
- OPERATIONAL

EFPC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead use ED?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use ED if i set the damper command as missing and then add the supply_fan_run_command
supply_air_linearvelocity_sensor
supply_fan_rotationalvelocity_sensor somewhere else?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-hereworks yes please use ED

  1. Use supply_fan_run_command by replacing SS with SFSS
  2. Use existing field supply_air_flowrate_sensor and delete supply_air_linearvelocity_sensor
  3. Add supply_fan_rotationalvelocity_sensor as optional on SFVSC (and make certain fields on that type missing, if needed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay and then can the fire and smoke alarms be added to the sfss?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest excluding the fire and smoke alarms from this type. Typically, we see those fields modeled as part of a SAFETY system.

Additionally, there is no need for this new type EFPC at all (now that you are using ED

description: "exhaust pressure monitoring, flow control."
is_abstract: true
opt_uses:
- exhaust_fan_run_command
- exhaust_fan_rotationalvelocity_sensor
uses:
- exhaust_air_flowrate_sensor
- exhaust_air_flowrate_setpoint
- exhaust_air_static_pressure_sensor
implements:
- OPERATIONAL

ESDC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a combination of EDM and SDM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, changed

description: "exhaust and supply air damper control."
is_abstract: true
opt_uses:
- exhaust_air_damper_status
- supply_air_damper_status
uses:
- exhaust_air_damper_command
- supply_air_damper_command
implements:
- CONTROL

FSAM:
description: "fire and smoke alarm monitoring."
is_abstract: true
uses:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add as optional on SS instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- fire_alarm
- smoke_alarm
implements:
- MONITORING

29 changes: 29 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/AHU.yaml
View file
Open in desktop
cstirdivant marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -3982,7 +3982,35 @@ AHU_SFSS_SFMSC_SFVSC_FDPM_CHWSC_RTM_RACO2C_SSPC2X_VOADM2X_SAIDC2X_RAIDC2X_SSPC:
- RAIDC2X
- SSPC

AHU_SS_RMM_RTM_FDPM_EFPC_SFPC_HWSC_ESDC_FSAM:
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You note that this unit has cooling, but there are not any cooling ABSTRACT types applied.

is_canonical: true
implements:
- AHU
- SS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use SFSS here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove SS and use SFSS

- RMM
- RTM
- FDPM
- EFPC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to use ED (and remove EFPC completely)

- SFPC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is SFPC? I don't see it defined in the ABSTRACT file

- HWSC
- ESDC
- FSAM

AHU_SS_RMM_STM_FDPM_EFPC_SFPC_HWRC_ESDC_FSAM:
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms supply and exhaust rotational velocity sensors"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You note that this AHU has cooling but I don't see any cooling ABSTRACT types (e.g., CHWSC, DXSC, etc.)

is_canonical: true
implements:
- AHU
- SS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use SFSS here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SFSS and remove SS

- RMM
- STM
- FDPM
- EFPC
- SFPC
- HWRC
- ESDC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is ESDC? I do not see this defined in the ABSTRACT file

- FSAM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is FSAM ? I do not see this defined in the ABSTRACT file

###################################
### Existing Non-standard Types ###
###################################
Expand Down Expand Up @@ -4814,3 +4842,4 @@ AHU_CHWSC_EFSS_EFVSC_FDPM3X_HTWHLSTC_HWSC_RCO2M_RSPC_SFM_SFSS_SFVSC_SSPC_VOADM_V
- SSPC
- VOADM
- VMADC

12 changes: 12 additions & 0 deletions ontology/yaml/resources/fields/telemetry_fields.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3110,3 +3110,15 @@ literals:
- ultraviolet_irradiance_sensor:
fixed_min: 0.0
flexible_max: 2000.0

- supply_air_linearvelocity_sensor:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being measured in liters per second (or some other flowrate unit)? If so, you can use the existing field supply_air_flowrate_sensor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its in meters per second unfortunately, we also have supply_air_flowrate_sensor on this device though

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using supply_air_flowrate_sensor and omitting the linear velocity sensor completely (as they are functionally redundant and the flowrate sensor is more useful for downstream applications)

fixed_min: 0.0
flexible_max: 25.4000508

- supply_fan_rotationalvelocity_sensor:
fixed_min: 0.0
flexible_max: 25.4000508

- exhaust_fan_rotationalvelocity_sensor:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unusual to see rotationalvelocity sensors. Are there more common measures like speed_percentage or speed_frequency that are available in your system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rotational velocity was used because the units on the reporting field are rpm, is this okay?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK to use rotationalvelocity if there are no speed_percentage or speed_frequency fields available in the system.

fixed_min: 0.0
flexible_max: 25.4000508