-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new ahu type #1003
base: master
Are you sure you want to change the base?
added new ahu type #1003
Changes from 10 commits
75c68de
52f6911
87bfe45
06e457c
79315fe
031b773
0e0a80a
a0e8792
63a438f
7ff1408
05bc8ad
50067c9
1fae0a3
ec53b92
35592d9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6618,3 +6618,52 @@ VMADC: | |
- mixed_air_damper_percentage_sensor | ||
implements: | ||
- CONTROL | ||
|
||
SFPC: | ||
description: "supply pressure monitoring, flow control." | ||
is_abstract: true | ||
opt_uses: | ||
- supply_fan_run_command | ||
- supply_air_linearvelocity_sensor | ||
- supply_fan_rotationalvelocity_sensor | ||
uses: | ||
- supply_air_static_pressure_sensor | ||
- supply_air_flowrate_sensor | ||
- supply_air_flowrate_setpoint | ||
implements: | ||
- OPERATIONAL | ||
|
||
EFPC: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we instead use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can use ED if i set the damper command as missing and then add the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kevin-hereworks yes please use
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. okay and then can the fire and smoke alarms be added to the sfss? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest excluding the fire and smoke alarms from this type. Typically, we see those fields modeled as part of a SAFETY system. Additionally, there is no need for this new type |
||
description: "exhaust pressure monitoring, flow control." | ||
is_abstract: true | ||
opt_uses: | ||
- exhaust_fan_run_command | ||
- exhaust_fan_rotationalvelocity_sensor | ||
uses: | ||
- exhaust_air_flowrate_sensor | ||
- exhaust_air_flowrate_setpoint | ||
- exhaust_air_static_pressure_sensor | ||
implements: | ||
- OPERATIONAL | ||
|
||
ESDC: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we use a combination of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, changed |
||
description: "exhaust and supply air damper control." | ||
is_abstract: true | ||
opt_uses: | ||
- exhaust_air_damper_status | ||
- supply_air_damper_status | ||
uses: | ||
- exhaust_air_damper_command | ||
- supply_air_damper_command | ||
implements: | ||
- CONTROL | ||
|
||
FSAM: | ||
description: "fire and smoke alarm monitoring." | ||
is_abstract: true | ||
uses: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add as optional on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
- fire_alarm | ||
- smoke_alarm | ||
implements: | ||
- MONITORING | ||
|
cstirdivant marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3982,7 +3982,35 @@ AHU_SFSS_SFMSC_SFVSC_FDPM_CHWSC_RTM_RACO2C_SSPC2X_VOADM2X_SAIDC2X_RAIDC2X_SSPC: | |
- RAIDC2X | ||
- SSPC | ||
|
||
AHU_SS_RMM_RTM_FDPM_EFPC_SFPC_HWSC_ESDC_FSAM: | ||
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You note that this unit has cooling, but there are not any cooling ABSTRACT types applied. |
||
is_canonical: true | ||
implements: | ||
- AHU | ||
- SS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to use SFSS here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove |
||
- RMM | ||
- RTM | ||
- FDPM | ||
- EFPC | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please update this to use |
||
- SFPC | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is |
||
- HWSC | ||
- ESDC | ||
- FSAM | ||
|
||
AHU_SS_RMM_STM_FDPM_EFPC_SFPC_HWRC_ESDC_FSAM: | ||
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms supply and exhaust rotational velocity sensors" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You note that this AHU has cooling but I don't see any cooling ABSTRACT types (e.g., CHWSC, DXSC, etc.) |
||
is_canonical: true | ||
implements: | ||
- AHU | ||
- SS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to use SFSS here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use |
||
- RMM | ||
- STM | ||
- FDPM | ||
- EFPC | ||
- SFPC | ||
- HWRC | ||
- ESDC | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is |
||
- FSAM | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is |
||
################################### | ||
### Existing Non-standard Types ### | ||
################################### | ||
|
@@ -4814,3 +4842,4 @@ AHU_CHWSC_EFSS_EFVSC_FDPM3X_HTWHLSTC_HWSC_RCO2M_RSPC_SFM_SFSS_SFVSC_SSPC_VOADM_V | |
- SSPC | ||
- VOADM | ||
- VMADC | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3110,3 +3110,15 @@ literals: | |
- ultraviolet_irradiance_sensor: | ||
fixed_min: 0.0 | ||
flexible_max: 2000.0 | ||
|
||
- supply_air_linearvelocity_sensor: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this being measured in liters per second (or some other There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its in meters per second unfortunately, we also have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest using |
||
fixed_min: 0.0 | ||
flexible_max: 25.4000508 | ||
|
||
- supply_fan_rotationalvelocity_sensor: | ||
fixed_min: 0.0 | ||
flexible_max: 25.4000508 | ||
|
||
- exhaust_fan_rotationalvelocity_sensor: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is unusual to see There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The rotational velocity was used because the units on the reporting field are rpm, is this okay? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is OK to use |
||
fixed_min: 0.0 | ||
flexible_max: 25.4000508 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead use a combination of
SSPM
andSFC
, along with maybeSFSS
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can if i add the rotational and linear velocity fields onto one of the suggested types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment below.