Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Docsy via Hugo module still works after Font Awesome upgrade #1165

Closed
Tracked by #1171
chalin opened this issue Aug 15, 2022 · 5 comments
Closed
Tracked by #1171

Ensure Docsy via Hugo module still works after Font Awesome upgrade #1165

chalin opened this issue Aug 15, 2022 · 5 comments
Labels
dependencies Pull requests that update a dependency file e0-minutes Effort < 60 min module p1-high

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 15, 2022

Task of:

@chalin
Copy link
Collaborator Author

chalin commented Oct 13, 2022

@geriom @deining - could either of you confirm?

@deining
Copy link
Collaborator

deining commented Oct 14, 2022

@geriom @deining - could either of you confirm?

I used HEAD of docsy repo, converted the userguidedir to module installation and could preview it without problems.

Dependencies:

$ hugo mod graph
hugo: collected modules in 1452 ms
hugo: collected modules in 1468 ms
github.com/deining/userguide github.com/google/docsy@v0.5.1-0.20221013201501-19ec7be59a8a
github.com/deining/userguide github.com/google/docsy/dependencies@v0.5.0
github.com/google/docsy/dependencies@v0.5.0 github.com/twbs/bootstrap@v4.6.2+incompatible
github.com/google/docsy/dependencies@v0.5.0 github.com/FortAwesome/Font-Awesome@v0.0.0-20220831210243-d3a7818c253f

Release 6.2.0 of FontAwesome translates to commit `d3a7818c253f``.

So coming back to four initial question: yes, modules still work with FontAwesome 6.2. 😄

@deining
Copy link
Collaborator

deining commented Oct 14, 2022

I can confirm the findings raised in #1281, so there are indeed some issues I overlooked.
Reopening the issue and investigating ...

@deining deining reopened this Oct 14, 2022
@deining
Copy link
Collaborator

deining commented Oct 14, 2022

I just submitted PR #1282. Once this PR is merged, module installation should work without any flaws.

@geriom
Copy link
Collaborator

geriom commented Oct 17, 2022

Merging #1284 solved this issue for me. If no further problems are reported we can can close it.

@geriom geriom closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file e0-minutes Effort < 60 min module p1-high
Projects
None yet
Development

No branches or pull requests

3 participants