Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link text and hover color contrast for all bgs #1525

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented May 26, 2023

Preview: https://deploy-preview-1525--docsydocs.netlify.app/about


Screenshots

These images show the fix in a block and the footer. The link contribution guidelines (roughly in the middle of the page) is in a hover state.

Before:

image

After:

image

@chalin chalin force-pushed the chalin-im-fix-link-and-hover-contrast-2023-05-26 branch from a70fca3 to 4e3cd57 Compare May 26, 2023 22:57
@chalin chalin requested review from LisaFC, deining and geriom May 30, 2023 11:33
@chalin chalin added this to the 23Q2 milestone May 31, 2023
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@geriom geriom merged commit 1b2ea51 into google:main Jun 1, 2023
6 checks passed
@chalin chalin deleted the chalin-im-fix-link-and-hover-contrast-2023-05-26 branch June 1, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants