Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't build: FATALgoogletest must be a sibling directory #731

Closed
yurivict opened this issue Aug 18, 2021 · 4 comments
Closed

Tests don't build: FATALgoogletest must be a sibling directory #731

yurivict opened this issue Aug 18, 2021 · 4 comments

Comments

@yurivict
Copy link

I already have the package googletest-1.11.0 installed, but tests expect googletest to be in a sibling directory?

Why googletest package isn't sufficient?

@tomfinegan
Copy link
Contributor

tomfinegan commented Aug 18, 2021

As the error message states: googletest must be a sibling directory of draco for the test build to succeed. The build script looks in one place, and if the source is not there an error is reported. Draco can be built without DRACO_TESTS enabled if you are, for whatever reason, unable to put googletest in a sibling directory.

Note: the gtest directory must be named 'googletest'.

@yurivict
Copy link
Author

Why do you need googletest sources when the package is available?
Is package not usable and sources are required instead?

@tomfinegan
Copy link
Contributor

It's simply how the CMake build locates the sources. If you'd like it to work differently I'd be happy to review a PR.

@yurivict
Copy link
Author

Shouldn't googletest be a git submodule then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants