Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window is missing postMessage #17

Closed
niloc132 opened this issue Nov 1, 2017 · 1 comment
Closed

Window is missing postMessage #17

niloc132 opened this issue Nov 1, 2017 · 1 comment

Comments

@niloc132
Copy link
Contributor

niloc132 commented Nov 1, 2017

Dovetailing into #16... it turns out that elemental2's Window actually doesn't have a postMessage!

https://www.w3.org/TR/2009/WD-html5-20090423/browsers.html#windowproxy shows it, but for some reason closure (and therefore elemental2) fails to allow it on the window object, only on global. In html5.js:

/**
 * This is a superposition of the Window and Worker postMessage methods.
 * @param {*} message
 * @param {(string|!Array<!Transferable>)=} opt_targetOriginOrTransfer
 * @param {(string|!Array<!MessagePort>|!Array<!Transferable>)=}
 *     opt_targetOriginOrPortsOrTransfer
 * @return {void}
 */
function postMessage(message, opt_targetOriginOrTransfer,
    opt_targetOriginOrPortsOrTransfer) {}

It should almost certainly be attached to Window.prototype as well, or instead of a static method.

@jDramaix
Copy link
Member

jDramaix commented Nov 1, 2017

feel free to open a bug in the closure repository and discuss there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants