Moe Sync #1179
Merged
Moe Sync #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*** Reason for rollback *** Retrying without the ImmutableMap change. It somehow seemed to interact with the build system in a weird way, but I'm not quite sure how. *** Original change description *** Automated rollback of 6c80a36. *** Original change description *** Mark WellKnownMutability as @immutable so that it can be a member of other @immutable classes Also a small drive-by cleanup to locate member variables in the same place and make a return type immutable. RELNOTES: Mark WellKnownMutability as @immutable. *** *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221498740
RELNOTES: N/A ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221578744
RELNOTES: add "getDefaultInstance" as a bad static method to import ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221650681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Automated rollback of 05560ec.
*** Reason for rollback ***
Retrying without the ImmutableMap change. It somehow seemed to interact with the build system in a weird way, but I'm not quite sure how.
*** Original change description ***
Automated rollback of 6c80a36.
*** Original change description ***
Mark WellKnownMutability as @immutable so that it can be a member of other @immutable classes
Also a small drive-by cleanup to locate member variables in the same place and make a return type immutable.
RELNOTES: Mark WellKnownMutability as @immutable.
8b3f721
Exclude @see tags from UnescapedEntity.
RELNOTES: N/A
8523d36
BadImport: add "getDefaultInstance" as a bad static method to import.
RELNOTES: add "getDefaultInstance" as a bad static method to import
7e0ded9