Add FieldCanBeStatic checker #930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbduncan
reviewed
Feb 12, 2018
| @@ -0,0 +1,62 @@ | |||
| /* | |||
| * Copyright 2017 The Error Prone Authors. | |||
| @BugPattern( | ||
| name = "FieldCanBeStatic", | ||
| category = JDK, | ||
| summary = "A final field with an immutable type can be static.", |
There was a problem hiding this comment.
I wonder if this summary would explain its corresponding bug checker's purpose better with a description like the following?
A final field initialized at compile-time with an instance of an immutable type can be static.
| " private final Object finalMutable = new Object();", | ||
| " private final int nonLiteral = new java.util.Random().nextInt();", | ||
| "}") | ||
| .doTest(); |
There was a problem hiding this comment.
@gaul I think it's worth adding another negative case where the final fields are initialized in a constructor, like one would with a POJO. So something like this:
class Person {
final String name;
final int age;
Person(String name, int age) {
this.name = name;
this.age = age;
}
}WDYT?
gaul
force-pushed
the
field-can-be-static
branch
2 times, most recently
from
8f04af8
to
9a6b056
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 13, 2018
Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time. Found via a proposed error-prone pull request: google/error-prone#930 MozReview-Commit-ID: CMj6vqFeCdI --HG-- extra : rebase_source : 43e91b3d8ff4bd8171ac25bd0b333d09645687a6
gaul
force-pushed
the
field-can-be-static
branch
from
9a6b056
to
582e14c
Compare
gaul
force-pushed
the
field-can-be-static
branch
from
582e14c
to
c6b95cc
Compare
|
Any chance this merge conflict can be resolved? |
This finds final fields which are initialized with a literal. Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time.
gaul
force-pushed
the
field-can-be-static
branch
from
c6b95cc
to
52b1ca7
Compare
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time. Found via a proposed error-prone pull request: google/error-prone#930 MozReview-Commit-ID: CMj6vqFeCdI UltraBlame original commit: e0a19b7fc6f6a44a990dacf210e871eda7eeddce
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time. Found via a proposed error-prone pull request: google/error-prone#930 MozReview-Commit-ID: CMj6vqFeCdI UltraBlame original commit: e0a19b7fc6f6a44a990dacf210e871eda7eeddce
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time. Found via a proposed error-prone pull request: google/error-prone#930 MozReview-Commit-ID: CMj6vqFeCdI UltraBlame original commit: e0a19b7fc6f6a44a990dacf210e871eda7eeddce
Merged
cgdecker
pushed a commit
that referenced
this pull request
May 20, 2020
This finds final fields which are initialized with a literal. Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time. Fixes #930 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=312137814
cgdecker
pushed a commit
that referenced
this pull request
May 20, 2020
This finds final fields which are initialized with a literal. Adding static reduces memory overhead from per-instance to per-class and allows initialization at compile-time instead of run-time. Fixes #930 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=312137814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finds final fields which are initialized with a literal. Adding
static reduces memory overhead from per-instance to per-class and
allows initialization at compile-time instead of run-time.