Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand e2e test to cover the single machine setup #509

Closed
Tracked by #606
, #535
...
bashir2 opened this issue Jan 31, 2023 · 3 comments · Fixed by #680
Closed
Tracked by #606
, #535
...

Expand e2e test to cover the single machine setup #509

bashir2 opened this issue Jan 31, 2023 · 3 comments · Fixed by #680
Assignees
@atulai-sg
Labels
enhancement New feature or request Mid-March Check-up P2:should An issue to be addressed in a quarter or so.
Milestone
Beta launch

Comments

@bashir2
Copy link
Collaborator

bashir2 commented Jan 31, 2023

In particular it should run docker-compose -f compose-controller-spark-sql.yaml up --build, generate Parquet files and run a SQL query against those through the thrift-server. It should also forces an incremental run to pick up new changes in the FHIR server.
@bashir2 bashir2 added enhancement New feature or request P2:should An issue to be addressed in a quarter or so. labels Jan 31, 2023
@bashir2 bashir2 mentioned this issue Jan 31, 2023
Merged
7 tasks
@bashir2 bashir2 changed the title Expend e2e test to cover the single machine setup Expand e2e test to cover the single machine setup Jan 31, 2023
@bashir2
Copy link
Collaborator Author

bashir2 commented Jan 31, 2023

To clarify: We already do the docker-compose command in the e2e run here but we should add the query part too (and full/incremental runs).

@jjtswan jjtswan mentioned this issue Feb 6, 2023
Open
@bashir2 bashir2 added this to the Beta launch milestone Feb 17, 2023
@yeswanthsubramanian yeswanthsubramanian mentioned this issue Feb 22, 2023
Closed
9 tasks
@jjtswan
Copy link
Collaborator

jjtswan commented Mar 6, 2023

We probably don't have time to do it for mid-march but should aim to add for Beta. To some degree we do have some test coverage thanks to William fixing up the documentation.

@bashir2 bashir2 mentioned this issue Mar 8, 2023
Open
3 tasks
@atulai-sg atulai-sg self-assigned this Mar 15, 2023
@jjtswan jjtswan mentioned this issue Mar 21, 2023
Open
6 tasks
@bashir2
Copy link
Collaborator Author

bashir2 commented Apr 4, 2023

@atulai-sg I just filed #632 but in the meantime we can just make a curl request to the controller endpoints to check the status of the pipeline.

@bashir2 bashir2 mentioned this issue Apr 20, 2023
Merged
7 tasks
@atulai-sg atulai-sg mentioned this issue May 4, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atulai-sg atulai-sg

Labels
enhancement New feature or request Mid-March Check-up P2:should An issue to be addressed in a quarter or so.
Projects
None yet
Milestone
Beta launch
Development

Successfully merging a pull request may close this issue.

Expanded e2e coverage by including single machine pipeline runs. atulai-sg/fhir-data-pipes
4 participants
@bashir2 @jjtswan @atulai-sg @yeswanthsubramanian