Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test coverage indicator as part of Continuous Integration. #666

Closed
Tracked by #606
atulai-sg opened this issue Apr 26, 2023 · 5 comments · Fixed by #694
Closed
Tracked by #606

Add unit test coverage indicator as part of Continuous Integration. #666

atulai-sg opened this issue Apr 26, 2023 · 5 comments · Fixed by #694
Assignees
Labels
enhancement New feature or request P2:should An issue to be addressed in a quarter or so.

Comments

@atulai-sg
Copy link
Collaborator

We should have a unit test coverage indicator to help identify developers whether or not they have increased or decreased coverage as part of their changes.

@bashir2
Copy link
Collaborator

bashir2 commented May 23, 2023

Thanks @atulai-sg for adding codecov back to our CB flow. I am reopening this issue to investigate the inconsistencies you reported in coverage numbers. Please feel free to close this and open another issue if that is more appropriate.

@bashir2 bashir2 reopened this May 23, 2023
@atulai-sg
Copy link
Collaborator Author

Hi @bashir2, I believe the inconsistencies can be tackled post beta.

@bashir2
Copy link
Collaborator

bashir2 commented Jun 2, 2023

Sounds good @atulai-sg I moved this to the post-beta follow-ups.

@bashir2 bashir2 added the P2:should An issue to be addressed in a quarter or so. label Feb 14, 2024
@bashir2
Copy link
Collaborator

bashir2 commented Feb 14, 2024

Hi @atulai-sg, just checking if you are planning to continue working on this and address review comments of #838? If not, please unassign this issue.

@atulai-sg atulai-sg removed their assignment Feb 15, 2024
@bashir2 bashir2 self-assigned this Feb 15, 2024
@bashir2 bashir2 mentioned this issue Mar 1, 2024
7 tasks
@bashir2
Copy link
Collaborator

bashir2 commented Mar 5, 2024

With PR #973, it seems that we now have coverage numbers reported in Codecov, e.g., here for master and here for a sample PR.

@bashir2 bashir2 closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2:should An issue to be addressed in a quarter or so.
Projects
None yet
2 participants