Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to require backports.zoneinfo on Python 3.9+ #37

Closed
gitpushdashf opened this issue Jun 15, 2021 · 2 comments
Closed

No need to require backports.zoneinfo on Python 3.9+ #37

gitpushdashf opened this issue Jun 15, 2021 · 2 comments

Comments

@gitpushdashf
Copy link

backports.zoneinfo on Python 3.9+ has to be compiled, so can't install in say the python:3.9-slim image.

pganssle/zoneinfo#105

I opened a PR, but got this big notice about signing a CLA. It's a very simple PR and I'm not sure if you can merge PRs here.

Feel free to reuse the two changed lines (if they even work) any way you please.

#36

Thank you! Let me know if you have any questions.

@Cam2337
Copy link
Collaborator

Cam2337 commented Jun 15, 2021

Thanks @gitpushdashf ! :)

Adding the guard to the installation in addition to our existing try/catch around our import statements makes sense!

I opened a PR, but got this big notice about signing a CLA. It's a very simple PR and I'm not sure if you can merge PRs here.

Feel free to reuse the two changed lines (if they even work) any way you please.

Unfortunately we don't have the ability to accept external PRs at the moment. I can incorporate+test this change and will push back to Github.

Thank you again!!

@gitpushdashf
Copy link
Author

Great! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants