Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] glTF KHR_materials_variants extension #4098

Closed
cx20 opened this issue Jun 7, 2021 · 7 comments
Closed

[Feature request] glTF KHR_materials_variants extension #4098

cx20 opened this issue Jun 7, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request gltf Specific to glTF support

Comments

@cx20
Copy link

cx20 commented Jun 7, 2021

Is your feature request related to a problem? Please describe.
Recently, some models using the KHR_materials_variants extension have been added to the Khronos glTF Sample models repository.
However, Filament does not support this extension, so I am unable to try it.

The following is an example of a model from the KHR_materials_variants extension.

Model Screenshot
Glam Velvet Sofa image
Materials Variants Shoe image
Sheen Chair image

Describe the solution you'd like
It is expected that support and sample code for the KHR_materials_variants extension will be provided.

Describe alternatives you've considered
I am testing some samples with gltf-test, but until this extension is supported, the test will be marked as Fail.

@romainguy romainguy added enhancement New feature or request gltf Specific to glTF support labels Jun 7, 2021
@romainguy
Copy link
Collaborator

It's something we'd like to support as well. It should be fairly easy since the concept of variants should map very well to our concept of MaterialInstance.

@issacclee
Copy link

Sorry to piggy back on this question.
For complex gltf model with multiple heavily textured material variants, it normally would make sense to also employ extensions such as KHR_texture_basisu to reduce the packaged assets transmission size.
Currently it seems filament doesn't support KHR_texture_basisu extension. I was wondering if the filament team would consider support it?

@cx20
Copy link
Author

cx20 commented Jun 21, 2021

@issacclee I think the following are issues related to KHR_texture_basisu.

#1378

@issacclee
Copy link

@issacclee I think the following are issues related to KHR_texture_basisu.

#1378

Ah, thanks!

@ThomasGorisse
Copy link
Contributor

ThomasGorisse commented Jun 23, 2021

Describe alternatives you've considered
I am testing some samples with gltf-test, but until this extension is supported, the test will be marked as Fail.

@cx20 Your repo rocks!
Thanks for your crazy work. It's very helpful.

@cx20
Copy link
Author

cx20 commented Apr 6, 2022

@prideout Thank you for supporting this extension. I have confirmed that this extension works with gltf-test.
https://github.com/cx20/gltf-test
image

@cx20 cx20 closed this as completed Apr 6, 2022
@cx20
Copy link
Author

cx20 commented Apr 6, 2022

#5361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gltf Specific to glTF support
Projects
None yet
Development

No branches or pull requests

5 participants