Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

big-endian should be tested automatically with CI #4939

Closed
rw opened this issue Sep 16, 2018 · 3 comments
Closed

big-endian should be tested automatically with CI #4939

rw opened this issue Sep 16, 2018 · 3 comments
Labels
c++ enhancement rust

Comments

@rw
Copy link
Collaborator

rw commented Sep 16, 2018

No description provided.

@rw rw self-assigned this Sep 16, 2018
@aardappel
Copy link
Collaborator

Not just in Rust, also for C & C++. I guess other languages are safe, since they tend to implement scalar writing with shifts or using explicit endianness aware functions.

@aardappel aardappel added the c++ label Sep 20, 2018
@aardappel aardappel changed the title Rust: big-endian should be tested, ideally with CI big-endian should be tested, ideally with CI Sep 20, 2018
@rw rw removed their assignment Sep 21, 2018
@rw rw changed the title big-endian should be tested, ideally with CI big-endian should be tested automatically with CI Sep 21, 2018
@tymcauley
Copy link
Contributor

Now that #5229 is merged, the Rust crate is now being built/tested with a big-endian target (mips-unknown-linux-gnu) in CI. See this file for more information:

https://github.com/google/flatbuffers/blob/9e82ee25275e07e35f489f6feac543611f81fb83/tests/docker/languages/Dockerfile.testing.rust.big_endian.1_30_1

@rw
Copy link
Collaborator Author

rw commented Mar 8, 2019

Yes, thanks @tymcauley for getting this to work!

@rw rw closed this as completed Mar 8, 2019
@barracuda156 barracuda156 mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ enhancement rust
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rw @aardappel @tymcauley